feat(writer): emit NULL_COUNT zone-maps for every column type#126
Merged
Conversation
NULL_COUNT is computable for any column, unlike MIN/MAX (primitives only). flushZoneMaps now emits a vortex.stats zone-map for every column: NULL_COUNT always, plus MIN/MAX when the column is a fixed-width primitive whose chunks all carry stats. The stat bitset varies per column (NULL_COUNT-only = 0x40, with MIN/MAX = 0x58). A NULL_COUNT-only table is a single-field struct, which the struct decoder collapses to the bare field; InspectorRender.formatStatsArray now renders that single-stat case instead of requiring a StructArray. Tests cover primitive (min/max + null_count), non-primitive Utf8 (null_count-only, per-zone counts), and the partial-stats fallback. Full writer/reader/cli/inspector suites green; 213 Rust JNI interop tests pass (Rust reads the null_count-only zone-maps on every column type). Co-Authored-By: Claude Opus 4.8 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NULL_COUNT is computable for any column, unlike MIN/MAX (primitives only).
flushZoneMaps now emits a vortex.stats zone-map for every column: NULL_COUNT
always, plus MIN/MAX when the column is a fixed-width primitive whose chunks
all carry stats. The stat bitset varies per column (NULL_COUNT-only = 0x40,
with MIN/MAX = 0x58).
A NULL_COUNT-only table is a single-field struct, which the struct decoder
collapses to the bare field; InspectorRender.formatStatsArray now renders
that single-stat case instead of requiring a StructArray.
Tests cover primitive (min/max + null_count), non-primitive Utf8
(null_count-only, per-zone counts), and the partial-stats fallback. Full
writer/reader/cli/inspector suites green; 213 Rust JNI interop tests pass
(Rust reads the null_count-only zone-maps on every column type).
Co-Authored-By: Claude Opus 4.8 [email protected]